Adminhelp + Screenshot + Switch Input hotkey fixes - #13091
Open
Drulikar wants to merge 7 commits into
Open
Conversation
This reverts commit 6e33ec8.
boskoramen
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR revives #12847 since it was abandoned. The primary purpose was to revert #10802 because it was unnecessary to need to change control freak settings to achieve this. I have also done a couple more things as well. Overall this PR does the following:
''s alsoSHIFT_CLICKis lowercase butkeys_heldwould haveShiftcapitalized), and makes them bound in hotkey set as F2 and Shift+F2 (I was going to use classic but that conflicts with OOC). It was very janky to be attempting to check if shift is pressed too because not only would hotkey system not fire with a modifier if it wasn't expecting that modifier, but it was not intuitive that you gotta bind it a certain way for different functionality.Regarding #12847 (review) it does seem to make things janky again, so I don't think it viable. It being present in
/datum/controller/subsystem/input/proc/setup_default_macro_sets()means if you have it default bound in/datum/keybinding/client/admin_helpit is double calling the ahelp. If you leave/datum/keybinding/client/admin_helpunbound, then you have ahelping occurring even if you unbound it intentionally; so I dunno if its worth fussing over somehow hotkeys being broken and then they can't ahelp (esc menu and the verb should still be options).Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Tinker with connecting and using the F1 hotkey and rebinding it to other things including say tgsay


Changelog
🆑 Drathek PoltavskaPraca
qol: Admin help is bound by default to F1 again for hotkey set
fix: Accessing options and messages and profiling is possible again
fix: Fixed incorrect triggering of conflicting keybinding detection for switch input key
fix: Screenshot auto is now possible again via hotkeys, broken up into two binds, and is bound to F2/Shift+F2 for the hotkey set
/:cl: