Skip to content

Adminhelp + Screenshot + Switch Input hotkey fixes - #13091

Open
Drulikar wants to merge 7 commits into
cmss13-devs:masterfrom
Drulikar:revive_12847
Open

Adminhelp + Screenshot + Switch Input hotkey fixes#13091
Drulikar wants to merge 7 commits into
cmss13-devs:masterfrom
Drulikar:revive_12847

Conversation

@Drulikar

@Drulikar Drulikar commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

About the pull request

This PR revives #12847 since it was abandoned. The primary purpose was to revert #10802 because it was unnecessary to need to change control freak settings to achieve this. I have also done a couple more things as well. Overall this PR does the following:

  • Reverts changes to control freak settings meaning options and messages and profiling are possible again
  • Changes the hotkey set to have F1 as a default bind for adminhelp (in addition to classic)
  • Sets the default binds for change input from null to unbound so it stops complaining about conflicts
  • Fixes/Splits up the screenshot hotkeys so that they're not two different bindable commands, auto can actually work now (command had a space that wasn't in ''s also SHIFT_CLICK is lowercase but keys_held would have Shift capitalized), and makes them bound in hotkey set as F2 and Shift+F2 (I was going to use classic but that conflicts with OOC). It was very janky to be attempting to check if shift is pressed too because not only would hotkey system not fire with a modifier if it wasn't expecting that modifier, but it was not intuitive that you gotta bind it a certain way for different functionality.

Regarding #12847 (review) it does seem to make things janky again, so I don't think it viable. It being present in /datum/controller/subsystem/input/proc/setup_default_macro_sets() means if you have it default bound in /datum/keybinding/client/admin_help it is double calling the ahelp. If you leave /datum/keybinding/client/admin_help unbound, then you have ahelping occurring even if you unbound it intentionally; so I dunno if its worth fussing over somehow hotkeys being broken and then they can't ahelp (esc menu and the verb should still be options).

Explain why it's good for the game

  • No longer necessary to edit control freak settings locally every time you want to profile
  • Easier for staff to debug say connection problems with a user if they can access the client log
  • Less confusion regarding the "conflicting" but not actually conflict switch input binding
  • Hopefully less confusion why F1 for ahelp doesn't work anymore when using hotkey default bindings (namely first join)
  • Working and intuitive screenshot hotkeys

Testing Photographs and Procedure

Screenshots & Videos

Tinker with connecting and using the F1 hotkey and rebinding it to other things including say tgsay
image
image

Changelog

🆑 Drathek PoltavskaPraca
qol: Admin help is bound by default to F1 again for hotkey set
fix: Accessing options and messages and profiling is possible again
fix: Fixed incorrect triggering of conflicting keybinding detection for switch input key
fix: Screenshot auto is now possible again via hotkeys, broken up into two binds, and is bound to F2/Shift+F2 for the hotkey set
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Sep 5, 2026
@cmss13-ci cmss13-ci Bot added Quality of Life Make the game harder to play Fix Fix one bug, make ten more size/S Denotes a PR that changes 19-49 lines, ignoring generated files. labels Sep 5, 2026
@github-project-automation github-project-automation Bot moved this from Awaiting Review to Partially Approved / Mergeable in Review Backlog Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fix one bug, make ten more Quality of Life Make the game harder to play size/S Denotes a PR that changes 19-49 lines, ignoring generated files.

Projects

Status: Partially Approved / Mergeable

Development

Successfully merging this pull request may close these issues.

3 participants