Repository navigation
testutil: point latestPatchInSeries at the CockroachDB release catalog - #293
Merged
Merged
Conversation
|
|
testdata/node.crt expired on 2026-09-24, so TestClientTLSConfig fails: "x509: certificate has expired or is not yet valid". The CA key was never committed, so node.crt cannot be re-signed by the old CA; ca.crt is replaced too. The new certificates keep the subjects, key usages and extensions of the old ones, and node.key is unchanged. The CA is valid for 20 years and node.crt for 10, until 2036. node.crt no longer lists a developer machine hostname as a SAN; the tests only need localhost.
StartCluster resolves "latest patch in a given series" by fetching CockroachDB release metadata and picking the newest non-withdrawn patch. It read cockroachdb/docs' releases.yml, which is now a stale mirror of the CockroachDB release catalog (https://binaries.cockroachdb.com/releases/v1/releases.yaml) and will stop being maintained. Switch to the catalog: its top level is a schema_version/releases mapping rather than a bare list, releases are keyed by "version" rather than "release_name", and there is no cloud_only field since the catalog never lists cloud-only builds. Also check the HTTP status of the download and reject any schema_version other than 1, neither of which the old code did.
rail
force-pushed
the
rail/release-catalog
branch
from
September 25, 2026 02:05
d546398 to
0d59bbd
Compare
sravotto
approved these changes
Sep 25, 2026
sravotto
left a comment
sravotto
left a comment
Contributor
There was a problem hiding this comment.
LGTM - thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/testutil/cluster.go'slatestPatchInSeriesresolvesCRDB_TEST_SERIES(used by CI's integration-test matrix) into a concretepatch version by fetching CockroachDB release metadata. It read
cockroachdb/docs'
releases.yml, which is now a stale mirror of theCockroachDB release catalog
(
https://binaries.cockroachdb.com/releases/v1/releases.yaml) and willstop being maintained.
This switches the reader to the catalog:
schema_version/releasesmapping, not abare list.
version, notrelease_name.cloud_onlyfield to filter on; the catalog never listscloud-only builds.
schema_versioncheck (must be1),neither of which the old code had.
Checked old vs. new against live data for the two series this repo's CI
actually pins (
25.4,24.3):24.3is unchanged (v24.3.36),25.4now correctly resolves to the newer
v25.4.17instead ofv25.4.16,since the docs copy is missing that patch.
No other files in the repo reference the old schema.
The first commit replaces
internal/http/testdata/{ca,node}.crt:node.crtexpired on 2026-09-24, which failsTestClientTLSConfigon main too.