Repository navigation
feat(messenger): show message send times in the chat - #1842
Merged
Merged
Conversation
A send time was only visible through the date separators, which on
Android appear after 3 hours of quiet.
- A left drag on the transcript slides the viewer's own bubbles 76dp
left and uncovers a column of send times; received bubbles stay put
and their times join the same column. It springs back on release.
The drag runs on the list's initial pointer pass, so a right drag
still reaches the row's swipe-to-reply, and a drag that starts in
the right edge's system gesture inset is left to predictive back.
- The selection bar's empty title slot shows the selected message's
full time ("Today, 6:13 PM").
- Each bubble adds its full time as a state description, so TalkBack
reads it after the message text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only way to see when a message was sent was the date separators, and on Android those appear only after 3 hours of quiet. Spec: code-payments/flipcash-client-orchestrator#57. iOS is implementing the same behavior in parallel.
SwipeToReply.ktis unchanged.MessageSelectionBarnow shows the selected message's full time, e.g. "Today, 6:13 PM", intextMedium.The full-time formatter is in chat-ui (
MessageTime.kt) so the bar and the bubble share it. New tests:MessageTimeTest,TimestampRevealTest, and aChatMessageActionScreenshotTestcase for the bar.The 3-hour separator gap is unchanged. It comes from
SeparatorConfig.Continuous(), where iOS uses 15 minutes.