Repository navigation
test(maestro): fix stale smoke flows after the Chats landing and tile changes - #1848
Merged
Merged
Conversation
…via Buy In/More Add Dollars sits under the floating nav pill at the end of the Wallet list and drops out of the accessibility tree, so the helper now scrolls to the end and a new tap helper falls back to the tile's visible top band. The Get flow looked for a Get tile that #1341 replaced with Buy In (Buy More on a held currency). open_tip_chat now fails with a clear message when CONTACT_NAME is empty.
The fallback ran after the label tap had already opened the Add Dollars With sheet, since the label was gone by then, and its tap at 25%, 86% landed on Other Wallet. Scrolling to the end of the list keeps the label in the tree, so the fallback is not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly Maestro smoke suite passes 9 of 13 flows on this branch (run 40126946160), up from 1 of 13 after #1824 and #1829. The four chat flows still fail because the
MAESTRO_CONTACT_NAMEandMAESTRO_CONTACT_PHONEsecrets are not set on the repo.These commits were pushed to
ci/maestro-emulator-bootafter #1824 merged, so they never reachedcode/cash. Fixes, one per cause:login_with_deeplink.yamlandlogin_usdf_only.yamlnow wait forchats_screen.create_account.yamlstill waits forwallet_screen, since new-account onboarding does land there.helpers/scroll_wallet_to_tile.yamlswipes from the left gutter until the tile label is visible, then swipes to the end of the list. It replacesscrollUntilVisiblein six flows.try_get_from_leaderboard.yamlmatches^Buy (In|More)$."", and the empty regex matched the status bar.open_tip_chat.yamlnow asserts the name is non-empty before tapping. Maestro reports this failure asfalse is true; the step label names the missing secrets.The bottom row of Wallet tiles still sits partly under the floating nav pill at the end of the list. Deposit passes because "Add Dollars" stays in the tree after scrolling to the end, but the layout itself looks wrong.
WalletScreenContent.ktis untouched here.coinbase_onramp.yamlandusdf_only_gate.yamluse the new scroll helper but are not in the smoke tag, so no run covered them.