Repository navigation
fix(messenger): stop the request deck crashing a chat on open - #1859
Merged
Merged
Conversation
The deck's pill sizes itself from its content's maxIntrinsicWidth, and the status line under the title drew through a SubcomposeLayout, which throws when asked for intrinsics. Any group chat whose front request has a share for the viewer crashed on open. FirstThatFits is now a plain Layout that composes both lines and places one, and reports the full line's width as its max intrinsic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a group chat whose front payment request has a share for the viewer crashes the app on code/cash after #1851:
The request pill sizes itself from its content's
maxIntrinsicWidth, and the viewer status line under the title ("You owe $2 · 7 days left") drew throughFirstThatFits, aSubcomposeLayout.FirstThatFitsis now a plainLayoutthat composes both lines, places the first one that fits, and reports the full line's width as its max intrinsic.FirstThatFitsTestasks the line for its intrinsic width the way the pill does; on the oldSubcomposeLayoutit throws the same exception.