Repository navigation
fix(messenger): clear the two lint errors from the request sheets - #1860
Merged
Merged
Conversation
lintDebug fails on code/cash with two errors from #1851: - NonObservableLocale: the time-to-pay day grid read Locale.getDefault() in composition, so it would miss a locale change. It reads LocalLocale.current.platformLocale now. - RememberReturnType: the remember that attaches the request deck before it is read returned Unit. It returns the attached chat now; attach still runs once per chat, before the deck is read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:apps:flipcash:app:lintDebugfails on code/cash (run 40400252946) with two errors that came in with #1851:TimeToPaySheet.kt:318NonObservableLocale: the day grid readLocale.getDefault()in composition, so it would not pick up a locale change. It readsLocalLocale.current.platformLocalenow, as lint suggests.MessengerScreen.kt:483RememberReturnType: therememberthat attaches the request deck before the deck is read returnedUnit. It returns the attached chat now (?.alsoin place of?.let).attachstill runs once per chat and before the deck is read, so a chat with known requests still shows its deck on the first frame.The CI log only names the first error; the second came from running
:apps:flipcash:features:messenger:lintDebuglocally.