Repository navigation
feat(flipcash): scaffold flipcash2 0.23.0 contract - #1876
Merged
Merged
Conversation
Add SendTestPush through api, service, repository and controller, EditChat rules with InvalidRules and RulesNotSatisfied errors, MetadataUpdate.RulesChanged, payment request updates on ChatUpdate, and RequestedPayment on sent/received activity metadata. Built against the local client override; the pin stays 0.22.0.
Persist the full replacement rules from the event stream. Payment request updates are surfaced on ChatUpdate but not yet applied (TODO).
github-actions
Bot
added
area: network
bmc08gt
marked this pull request as ready for review
October 29, 2026 03:53
github-actions
Bot
added
the
area: build-system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scaffolds the flipcash2
0.23.0contract and bumpsflipcash2-client-protocolfrom0.22.0to0.23.0. Client PR: code-payments/flipcash2-client-protocol#31SendTestPush:PushApi→PushService→PushRepository→PushController, returningResult<Unit>withSendTestPushError.EditChatrules:EditChatParameters.rulessends the full rule set. NewEditChatError.InvalidRulesandRulesNotSatisfied.RulesChanged: mapped toMetadataUpdate.RulesChangedand persisted byEventStreamDelegatethrough a newChatMetadataDao.updateRules. It reuses therules_jsoncolumn, so there is no schema change.ChatUpdate.paymentRequestUpdatescarries a newPaymentRequestUpdatedomain type. A missing share or an unknown kind maps toUnknown, meaning refetch. Nothing applies the updates yet; that is aTODO(flipcash2 0.23.0)inEventStreamDelegate.RequestedPayment:requestedPaymenton the directly-sent and received notification metadata, next toboostedReaction.No UI. No new unit tests for the new mappers.