Repository navigation
fix(notification-status): pop every test push and title rows by check name - #1878
Merged
Merged
Conversation
A second test sent while the first is still in the shade joined an Android 16 auto-group (g:Aggregate_AlertingSection), which posted it with FLAG_SILENT, so it never popped. Posting every test under one id replaces the last one instead. Other pushes keep a random id; chats keep their chat id.
A row with a problem was titled with the problem sentence, so "Battery
Optimization" became "Battery optimization is on" and the row changed
name with its state. The title is now the check name in every state;
blocked channels are titled by channel ("Chat Notifications") and the
registration row stays "Registered for Push" while it checks. On a
warning or fail the problem sentence leads the detail and the
explanation, if any, is its second line. The report is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to the notification status page from #1874.
A second test notification didn't pop up
Sending a test while the previous one was still in the shade posted the new one silently. Each test went out under a random id, so on Android 16 the second one joined an auto-group with the first (
g:Aggregate_AlertingSection) and SystemUI loggedPEEK suppressed: notification isSilent. The test push now always posts under one fixed id,TEST_PUSH_NOTIFICATION_ID(0x7E57), so a new test replaces the last one and still alerts, since the builder doesn't setonlyAlertOnce. Other pushes keep a random id, and chats keep their chat id.planNotificationIdpicks the id and has unit tests.On the
invites_androidemulator (Android 16, API 36), I sent a test, then a second one while the first was still in the shade. The shade held one Flipcash notification, id 32343, both times, and SystemUI showed both as heads-up:Row titles changed when a check failed
A row with a problem was titled with the problem sentence, so "Battery Optimization" became "Battery optimization is on". The title is now the check name in every state. On a warning or fail, the problem sentence is the first line of the detail and the explanation, if there is one, is the second. Blocked channel rows are titled by channel ("Chat Notifications", "Misc. Notifications"), and the registration row is "Registered for Push" while it checks, with "Contacting Flipcash" as the detail. The share report is unchanged.
checkTitlepicks the title from the row's key alone, andproblemLinepicks the problem sentence.CheckRowTitlesTestchecks that every row key has a title, that pending, rechecking, passing and failing rows share it, and that every warning or fail row has a problem line and no passing row does.On the same emulator, with battery optimization on, the row reads "Battery Optimization" over "Battery optimization is on" / "Android may delay notifications", with Fix beside it. The other rows keep their names: "Notifications Allowed", "Other Categories", "Background Activity", "Google Play Services" and "Registered for Push".