Repository navigation
fix(requests): suggest another currency when a share can't be covered - #1879
Merged
Merged
Conversation
A request share is a fixed amount, so "enter a smaller amount" had no way to act on it. RequestPayFlow now passes its own subtitle to presentInsufficientBalance: "Add more money, or pay with a different currency". Other callers keep the default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The insufficient balance sheet for paying a request said "Add more money, or enter a smaller amount", but a request share is a fixed amount. It now says "Add more money, or select a different Community Currency".
presentInsufficientBalancetakes an optionalmessage, andRequestPayFlowpassesdescription_insufficientBalanceToPayRequest. Chat sends, currency sends and boosts keep the existing subtitle.iOS gets the same change in code-payments/code-ios-app#1161.