Repository navigation
chore(skills): add propose-analytics-event - #1885
Merged
Merged
Conversation
A skill for non-engineers to propose analytics events in plain English. It interviews the proposer, checks the catalogue for existing coverage, and opens a draft PR that edits only events.toml, EVENTS.md, the event test and the SharedCoreKit typealias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
/propose-analytics-event, so someone outside engineering can propose a Mixpanel event by describing it in plain English. Claude Code (including claude.ai/code) on this repo is enough; they don't need the orchestrator or a local Android setup.The skill:
events.tomland the call sites first, and sorts each ask into: already tracked, catalogued but unsent, a Mixpanel report on existing events, something the app can't see (installs from a link, anything after the Share menu), or a new event;events.toml,EVENTS.md, the domain's*EventsTest.ktand the SharedCoreKit typealias. It changes no app code;Tested with the same three-part marketing request with and without the skill. Without it, the agent guessed what "share" meant, asked its questions after building, and wired a ViewModel. With it, the agent asked first, covered all three share paths, routed "engaged" to a Mixpanel report, and declined to relabel
Group: Invite Followedas an install count.Step 6 runs
writeAnalyticsEventsPageandcheckAnalyticsEventsPageas separate Gradle invocations. In one invocation, the check can run before the write and fails even on a clean tree. The underlying fix is amustRunAfterinAnalyticsCatalogueConventionPlugin, which this PR leaves alone.