Skip to content

chore(skills): add propose-analytics-event - #1885

Merged
bmc08gt merged 2 commits into
code/cashfrom
chore/propose-analytics-event-skill
Oct 30, 2026
Merged

bmc08gt merged 2 commits into
code/cashfrom
chore/propose-analytics-event-skill

Conversation

@bmc08gt

@bmc08gt bmc08gt commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

Adds /propose-analytics-event, so someone outside engineering can propose a Mixpanel event by describing it in plain English. Claude Code (including claude.ai/code) on this repo is enough; they don't need the orchestrator or a local Android setup.

The skill:

  • asks what decision the number feeds, the exact moment it counts (tapped vs. completed), and the breakdowns, offering choices from the real screens;
  • checks events.toml and the call sites first, and sorts each ask into: already tracked, catalogued but unsent, a Mixpanel report on existing events, something the app can't see (installs from a link, anything after the Share menu), or a new event;
  • edits only events.toml, EVENTS.md, the domain's *EventsTest.kt and the SharedCoreKit typealias. It changes no app code;
  • opens a draft PR with a "where to send it" section for whoever wires it, and stays draft because the catalogue claims both apps send every entry.

Tested with the same three-part marketing request with and without the skill. Without it, the agent guessed what "share" meant, asked its questions after building, and wired a ViewModel. With it, the agent asked first, covered all three share paths, routed "engaged" to a Mixpanel report, and declined to relabel Group: Invite Followed as an install count.

Step 6 runs writeAnalyticsEventsPage and checkAnalyticsEventsPage as separate Gradle invocations. In one invocation, the check can run before the write and fails even on a clean tree. The underlying fix is a mustRunAfter in AnalyticsCatalogueConventionPlugin, which this PR leaves alone.

A skill for non-engineers to propose analytics events in plain English.
It interviews the proposer, checks the catalogue for existing coverage,
and opens a draft PR that edits only events.toml, EVENTS.md, the event
test and the SharedCoreKit typealias.
@bmc08gt bmc08gt self-assigned this Oct 29, 2026
@github-actions github-actions Bot added the type: chore Maintenance, config, CI/CD label Oct 29, 2026
@bmc08gt
bmc08gt merged commit 31eb818 into code/cash Oct 30, 2026
5 checks passed
@bmc08gt
bmc08gt deleted the chore/propose-analytics-event-skill branch October 30, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore Maintenance, config, CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant