Skip to content

feat(analytics): send the Profile events - #1887

Merged
bmc08gt merged 1 commit into
code/cashfrom
feat/analytics-profile-events
Oct 30, 2026
Merged

bmc08gt merged 1 commit into
code/cashfrom
feat/analytics-profile-events

Conversation

@bmc08gt

@bmc08gt bmc08gt commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

The seven Profile: * events were catalogued on Oct 6 and nothing sends them, so none reach Mixpanel. This wires each builder.

Event Function Moment
Profile: Settings Viewed SettingsViewModel init screen opened
Profile: Edit Profile Viewed EditProfileViewModel init screen opened
Profile: Field Saved NameEntryViewModel, UsernameEntryViewModel, PhotoSelectionViewModel (Avatar = Photo, Cover = Cover), EditBioViewModel, MinimumTipEntryViewModel after the set call succeeds; never on failure
Profile: Bio Moderation Failed EditBioViewModel.handleSaveFailure SetBioError.FailedModerated only, not InvalidBio or generic errors
Profile: Menu Action ChatProfileViewModel (MenuActionPicked, dispatched from the menu onItem before routing) tap on Mute, Report, Block or Unblock; Silence and Remove send nothing
Profile: Pinned Button Tapped ChatProfileViewModel PinnedActionTapped handler StartChatting, OpenChat (sent before the dmChatId null check), Unblock; OpeningChat sends nothing
Profile: Card Shown ProfileCardViewModel init screen opened, not gated on the card load

Judgment calls:

  • Name sends Field Saved only when the source is MyAccount. Onboarding and tip-card setup are already counted by Display Name: Set.
  • Menu Action counts Block on the tap, before its confirmation sheet, so a dismissed sheet still counts.

MinimumTipEntryViewModel has no ViewModel test: it builds an AmountEntryDelegate and TipPaymentDelegate, which the existing fakes don't cover.

The seven Profile events were catalogued but nothing sent them. Wire each builder at its screen or save point and cover each send, and each path that must stay silent, with RecordingAnalytics.
@bmc08gt bmc08gt self-assigned this Oct 30, 2026
@github-actions github-actions Bot added the type: feature New functionality label Oct 30, 2026
@bmc08gt
bmc08gt marked this pull request as ready for review October 30, 2026 00:32
@bmc08gt
bmc08gt merged commit 336bf4c into code/cash Oct 30, 2026
5 checks passed
@bmc08gt
bmc08gt deleted the feat/analytics-profile-events branch October 30, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature New functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant