Repository navigation
fix(skills): open analytics proposals from a fork without push access - #1895
Merged
Merged
Conversation
propose-analytics-event pushed to origin and requested a reviewer, both of which fail for someone without write access to the repo. It now checks viewerPermission and, below WRITE, forks the checkout, pushes there, opens the PR against code/cash, and cc's the reviewer in the body instead of using --reviewer and --assignee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/propose-analytics-eventpushed tooriginand passed--reviewerand--assignee. Someone without write access tocode-android-appfails at the push, and GitHub won't let them request reviewers or set assignees either.Step 7 now checks
viewerPermissionfirst:WRITE,MAINTAINorADMIN: no change.gh repo fork --remote --remote-name forkfrom inside the checkout, push tofork, thengh pr create --repo code-payments/code-android-app --head <login>:<branch>. The PR is still a draft againstcode/cash. It drops--reviewerand--assigneeand ends the body with a cc to bmc08gt instead.Fork PRs from a first-time contributor don't run CI until a maintainer approves the run. The skill now tells the person that, instead of waiting on
gh pr checkswith no checks to watch. If a check fails for a reason unrelated to the catalogue, such as a secret forks can't read, it leaves the failure for the reviewer.The fork route hasn't run end to end. My account has
MAINTAINon this repo, so it always takes the first branch.