Skip to content

fix(resources): read Compose strings through the Compose loader on Android #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Oct 30, 2026
Merged

fix(resources): read Compose strings through the Compose loader on Android #1911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions ui/resources/src/androidMain/kotlin/com/getcode/util/resources/AndroidResources.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ import androidx.annotation.RawRes
import androidx.annotation.StringRes
import androidx.appcompat.content.res.AppCompatResources
import androidx.core.content.res.ResourcesCompat
import kotlinx.coroutines.runBlocking
import org.jetbrains.compose.resources.StringResource
import org.jetbrains.compose.resources.getString as getComposeString
import timber.log.Timber
import java.io.File

Expand All @@ -26,12 +28,11 @@ class AndroidResources(
return context.getString(resourceId, *formatArgs)
}

// Compose resources keep the Android resource name as their key, and every module's resources are
// merged into the app package, so the key resolves to the same R entry Android always read.
override fun getString(resource: StringResource, vararg formatArgs: Any): String {
val id = getIdentifier(resource.key, ResourceType.String) ?: return ""
return context.getString(id, *formatArgs)
}
// Read through the Compose loader (the packaged composeResources assets), not R by the resource's
// key: a string reached only through that name lookup looks unused to the release resource
// shrinker, which strips it, so every such title rendered blank in shipped builds.
override fun getString(resource: StringResource, vararg formatArgs: Any): String =
runBlocking { getComposeString(resource, *formatArgs) }

override fun getRawResource(@RawRes resourceId: Int): String {
return try {
Expand Down
Loading