Repository navigation
feat(group): edit join and chat balance requirements from Edit Group - #1017
Merged
Merged
Conversation
The Join and Chat rows in Edit Group now open the amount entry screen, and the card shows on groups with no requirement so one can be added. Saving is stubbed: flipcash2-client-protocol 0.18.0 has no RPC that changes a group's rules after StartChat (EditChatRequest carries only title, description and pictures). SessionGroupChatEditor.setMinimumBalance throws .unavailable, which shows "Not Available Yet" and isn't reported. That method body is the one place to wire the RPC when it lands.
A member short of the listener minimum keeps reading and can't speak, as when their balance falls, instead of losing the transcript. Group link cards read the stored rules, and reopening a group the viewer has left refetches its rules so a rejoin is weighed against them.
bmc08gt
force-pushed
the
feat/group-balance-requirement-edit
branch
from
October 29, 2026 12:08
cedbe69 to
43a4651
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Join and Chat rows under Balance Requirements in Edit Group open the same amount entry screen Minimum To Chat uses, and Save now changes the group's rules through
EditChat(EditChatRequest.rules, flipcash2-client-protocol 0.23.0). Depends on #1157 for the 0.23.0 scaffolding.What the server accepts
EditChatreplaces the whole rule set and accepts less than the earlier stub assumed, so the editor now follows the contract:ConversationRuleskeeps the serialized proto it was decoded from, andConversationRulesEditedits that, becauseConversationRules(proto)drops rules it doesn't recognise.Database.schemaVersionis 61 for the new field.ErrorEditChat.invalidRulesand.rulesNotSatisfiedmap to "This Requirement Isn't Valid" and "You Don't Meet This Requirement". The.unavailablepath and "Not Available Yet" are gone.Members follow a change live
applyEditseats the returned rules, and the stream'sRulesChangedalready lands in the store, so the gates and profile rows that read the stored conversation update without a reopen. Three gaps closed:A
RulesChangedwhose Join requirement uses a currency this client can't decode is ignored, keeping the old gate. Applying it would turn a gated group ungated, and a refetch decodes the same way.