Repository navigation
fix(chat): lower the keyboard before opening a request or join requests - #1150
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a request from a chat while the keyboard is up presented the new screen over the raised keyboard. The composer is a UIKit layer that keeps focus, so none of these SwiftUI presentations lowered it.
ConversationScreen.afterKeyboardLowered(_:)runs a presentation once the keyboard is out of sight. If the keyboard is up, it callsKeyboardSuppressor.lower()and waits for the hide; otherwise it runs straight away. Resigning focus also stops the keyboard coming back when the presentation closes.KeyboardHideWaitermoves out ofChatSearchScreen.swiftintoFlipcash/Utilities/so both screens share it. No behaviour change in search.Send Money (
presentSendAmount) is unchanged and may still open over the keyboard.