Repository navigation
fix(notifications): word a pushed payment request from its lookup - #1155
Merged
Merged
Conversation
A chat push for a payment request carried only the request id, so the banner kept the server's generic body and the expanded transcript drew a bare 'Payment request'. The notification service now fetches the request with a 4s deadline, opens its title with the chat's seal, and replaces the body with '<first name> sent request for <title> · <amount>'. The preview cache gets the real card. Any failure keeps the server body and the card-less row. PaymentRequestCopy, PaymentRequestText and the card initializer move into FlipcashCore so the extension and the app word requests identically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A chat push for a payment request carries only the request id. The banner kept the server's generic body, and the expanded transcript drew a bare "Payment request" (
ChatPreviewMappingbuilt the card asnil).The notification service now fetches the request through a new
ChatNotificationClient.paymentRequestPreview, with a 4s gRPC deadline. It opens the title with the chat seal it already derives, and replaces the body with "{first name} sent request for {title} · {amount}", the same wording as the chat list. The preview cache now gets the real card, so the expanded view shows the title. If anything fails, the server's body and the card-less row stay as they were.PaymentRequestCopy,PaymentRequestTextand the card initializer move from the app into FlipcashCore, so the extension and the app word requests the same way instead of keeping two copies.getPaymentRequesttakes an optionaltimeout, which defaults to 15s, so existing callers don't change.Only the request lookup has a deadline. The
getChatcall for the seal does not, butserviceExtensionTimeWillExpirestill delivers the original content. Tapping still opens the chat.