Repository navigation
fix(payments): route Add Money from confirm sheets - #1156
Merged
Merged
Conversation
… Money from confirm sheets Paying a request without enough funds only checked after the swipe. Request pay now checks funds in prepare() and, when short, shows the insufficient-funds dialog (with Add More Cash) instead of opening the swipe sheet. Currency Info send now observes depositMint, so Add More Cash routes to the deposit instead of doing nothing. For request pay, group send and Currency Info send, Add Money tapped while the confirm sheet is up closes that sheet first and navigates once it has dismissed, since the router cannot dismiss a local sheet. Failed swipes still leave the sheet up with the dialog over it.
bmc08gt
force-pushed
the
fix/insufficient-funds-over-sheet
branch
from
October 28, 2026 18:41
e1de11e to
f38d213
Compare
bmc08gt
changed the title
The payer picks the token in the swipe sheet, so checking the token selected before the sheet opens blocked payers who hold the funds in another currency. prepare() no longer checks funds; a ready share opens the pay sheet as before. The post-swipe check in submit() still runs against the picked token, and its insufficient-funds dialog keeps the Add More Cash action.
bmc08gt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Currency Info send, "Add More Cash" in the insufficient-funds dialog did nothing, and Add Money from a confirm sheet could navigate while that sheet was still up. A failed swipe still leaves the sheet up with the dialog over it, as on
main.CurrencySendFlownever observeddepositMint; it now does, on the confirmed send's model.router.navigate(.currencyInfoForDeposit)dismisses router sheets but not a local one, so each flow closes its confirm sheet and navigates fromonDismiss.submit()runs against the token picked in the sheet. Pressing Send still opens the sheet without a balance check, since the payer can pick any token in the wallet there.InsufficientFundsSheetTestscovers thedepositMintrouting on Currency Info send.