Repository navigation
fix(notifications): title each row with its check name in every state - #1160
Merged
Merged
Conversation
A warning or fail used to replace the title with the problem, so "Notifications Allowed" became "Notifications are turned off". The title now stays the check name, and the problem moves to the detail's first line, with the explanation, if any, on the second. The checking registration row is "Registered for Push" too, over "Contacting Flipcash".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A row's title is now its check name in every state, Checking included. Before, a warning or fail replaced the title with the problem. Now the problem sentence moves to the detail's first line, and the explanation, if there is one, goes on the second:
Notifications are turned off
Turned off for Flipcash in iOS Settings
The checking registration row reads "Registered for Push" over "Contacting Flipcash", not "Checking registration…".
The share report is unchanged. It already labels each line with
row.check.nameand the raw value, not the row title.This follows #1153. The commit landed on
feat/notification-statusafter the squash merge, somainstill has the old titles. #1153's description already describes this behavior.Spec:
docs/specs/notification-status.mdincode-payments/flipcash-client-orchestrator, Copy section.