Skip to content

feat(analytics): send the Profile events - #1167

Open
bmc08gt wants to merge 1 commit into
mainfrom
feat/analytics-profile-events
Open

bmc08gt wants to merge 1 commit into
mainfrom
feat/analytics-profile-events

Conversation

@bmc08gt

@bmc08gt bmc08gt commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

The shared catalogue has had seven Profile events since Oct 6, and nothing sends them. The builders are already in the pinned SharedCore 0.17.0 (ProfileEvents, via SharedCoreKit), so there is no package bump or local override.

Event Function Moment
Profile: Settings Viewed YouScreen.settingsGear tap, before router.push(.settings)
Profile: Edit Profile Viewed YouScreen ProfileEditCapsule tap, before router.push(.editProfile)
Profile: Field Saved (Field) ProfileNameScreen.save, UsernameEntryScreen.claim, ProfilePhotoScreen.upload, ChangeCoverPictureScreen.upload, EditBioModel.save, SetMinimumTipScreen.save after the set RPC succeeds, before the profile refresh; never on failure
Profile: Bio Moderation Failed EditBioModel.save the ErrorProfile.moderated catch only
Profile: Menu Action (Action) UserProfileScreen.perform the pick: mute, report, block, unblock. Silence and Remove from Group send nothing
Profile: Pinned Button Tapped (Action) UserProfileScreen.tapPinned the tap, before the give-cash gate. .none sends nothing
Profile: Card Shown ProfileCardScreen .onAppear card shown

The menu-item and pinned-action mappings live in ProfileMenuItem.analyticsAction and ProfilePinnedAction.analyticsAction, returning nil for the cases that send nothing. Wrappers are in Events.swift; ProfileEventsTests covers each wrapper, the nil cases, and EditBioModel for Field Saved (Bio) and Bio Moderation Failed.

Judgment calls:

  • Name is sent only when the display-name source is .myAccount. .tipCardSetup and onboarding send no Field Saved.
  • Settings and Edit Profile count on the tap, not .onAppear, which would refire on pop back.
  • Menu Action counts Block on the pick, before its confirm dialog, so a cancelled block still counts.

@bmc08gt bmc08gt self-assigned this Oct 30, 2026
@bmc08gt
bmc08gt marked this pull request as ready for review October 30, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant