Repository navigation
Conversation
bmc08gt
marked this pull request as ready for review
October 30, 2026 00:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared catalogue has had seven Profile events since Oct 6, and nothing sends them. The builders are already in the pinned SharedCore 0.17.0 (
ProfileEvents, via SharedCoreKit), so there is no package bump or local override.YouScreen.settingsGearrouter.push(.settings)YouScreenProfileEditCapsulerouter.push(.editProfile)ProfileNameScreen.save,UsernameEntryScreen.claim,ProfilePhotoScreen.upload,ChangeCoverPictureScreen.upload,EditBioModel.save,SetMinimumTipScreen.saveEditBioModel.saveErrorProfile.moderatedcatch onlyUserProfileScreen.performUserProfileScreen.tapPinned.nonesends nothingProfileCardScreen.onAppearThe menu-item and pinned-action mappings live in
ProfileMenuItem.analyticsActionandProfilePinnedAction.analyticsAction, returning nil for the cases that send nothing. Wrappers are inEvents.swift;ProfileEventsTestscovers each wrapper, the nil cases, andEditBioModelfor Field Saved (Bio) and Bio Moderation Failed.Judgment calls:
.myAccount..tipCardSetupand onboarding send no Field Saved..onAppear, which would refire on pop back.