Repository navigation
feat(analytics): send the batch catalogue events - #1170
Merged
Merged
Conversation
Wires the events catalogued in code-android-app#1889, #1890 and #1891: invite links, join requests, member silence and removal, Search, Currency Info tiles, New Chat type, Sent Boost, payment requests, and Sent Cash Context and Recipient Count. Moves iOS-only names onto the catalogue builders. Gallery Scan now sends the catalogue's Succeeded and Failed events instead of Code Found and Nothing Found, so those Mixpanel series stop on the release that ships this. Deletes six event names nothing sent any more. Needs a SharedCore release that includes those three PRs; it builds today only with FLIPCASH_SHARED_CORE_LOCAL.
0.18.0 carries the catalogue entries from android #1889, #1890 and #1891, which the analytics wiring in this branch calls.
bmc08gt
marked this pull request as ready for review
October 30, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sends the events catalogued in code-payments/code-android-app#1889, #1890 and #1891. Until now iOS sent nothing for invite links, join requests, moderation, Search, the Currency Info tiles, boosts or payment requests.
This stays a draft until a SharedCore release includes those three PRs. The current pin, 0.17.0, has none of the new builders, so CI will fail; locally it builds with
FLIPCASH_SHARED_CORE_LOCALpointed at a merge of the three catalogue branches. Once the release is out, the pin bump goes in all threePackage.swiftfiles on this branch.New events
Analytics.chatResultnow maps the invite, lobby and moderation errors, which used to report asNetwork.Token Info: Opened From Searchinstead of Discovery.Group: New OpenedgetsType(Private or Community).Changed events
Sent CashgetsContext(Direct, Group Send or Payment Request) at every call site, andRecipient Countfor group sends. Paying a request (PaymentRequestPayment.swift) now sendsContext = Payment Requestinstead of an untaggedSent Cash.SucceededandFailedevents.Gallery Scan: Code FoundandNothing Foundstop on the release that ships this, so any Mixpanel chart on them needs to switch names at that version. QR and Kik finds are no longer told apart, because the shared event has no type. A cancelled scan reportsExhausted = true.Owner Public Key.Removed: six names nothing sent any more:
Button: Allow Camera,Button: Sell,Send: Show Enter Phone,Send: Show Confirm Phone,Wallet: Transactions SubmittedandWallet: Transactions Failed.Approving a join request treats
notInLobbyas success, matching how the screen handles it. A request that was already resolved isn't counted as a failure.CatalogueBatchEventsTests,GroupEventsTestsandMigratedEventsTestspass against the local SharedCore build (59 tests).