Repository navigation
chore(contract): sync ocp protos to 98cf14de (0.9.0) - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
transaction.v1toocp-protobuf-api@98cf14de(#71), for release as 0.9.0.The server side is code-payments/ocp-server#278. It builds CoinbaseStableSwapper's
swap_v2instruction when the client asks for it.swap_v2isswapwithout the deprecated whitelist account.Contract diff
swap_version(uint32,lte = 2) is added to the CoinbaseStableSwapper initiate params ofStatefulSwapRequest(field 9) andStatelessSwapRequest(field 4). Only2selectsswap_v2. Unset,0and1keep the legacyswap.SwaporSwapV2, perswap_version.The
CHANGELOG.mdentry for 0.9.0 is in this PR, sopublish.ymlcan run once it merges.App PRs
Both are drafts until 0.9.0 is published and their pins move:
Neither app should ship v2 before code-payments/ocp-server#278 is deployed. An older server ignores
swap_versionand buildsswap, the app signsswap_v2, and the swap fails.