Repository navigation
docs: install from the 0.1.0 release, and fetch the unit from its tag - #85
Merged
Merged
Conversation
The README, the setup guide and SECURITY.md still said that there is no release. The install steps now offer the release first: download the tarball and SHA256SUMS on a trusted machine, check them as docs/releasing.md says, copy the file straight to each machine, and check its SHA-256 on the broker host. Building from the source stays as the second way. The release tarball does not hold the systemd unit. Section 8 and the upgrade steps in section 13 now fetch it from the tag of the version, named as refs/tags/... so that a branch with the same name cannot serve a changed unit, and never through an agent machine. Closes #81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #81.
What changes
SHA256SUMS, checked asdocs/releasing.mdsays, copied straight to each machine, SHA-256 checked on the broker host). Building from the source stays as the second way.nodkey,LICENSEandREADME.md. The guide now says where to get the unit: from the tag of your version, on the broker host or the trusted machine, never through an agent machine. Whoever can change the unit can run a program as root on the broker host.contrib/folder, so the step downloads the unit of the new version and compares it.refs/tags/v0.1.0in the URLs. GitHub blocks branch names that start withrefs/, so a branch namedv0.1.0cannot serve a changed unit.The Bitwarden part (#82) follows in its own PR.
Review
A security review subagent checked it in three rounds. All links and anchors resolve. Docs only; no code changes.