Repository navigation
ci: publish the attestation bundle with each release - #91
Merged
Merged
Conversation
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each release now also has
nodkey_<version>.sigstore.json: the build provenance attestation of both tarballs, as one Sigstore bundle. With this file,gh attestation verify --bundleneeds no GitHub login. Without it, gh needs a login even for this public repository (cli/cli#11803). A broker host should have no GitHub login. The installer andnodkey update(#88) will use this file.Changes
.github/workflows/release.yml,publishjob:id. A new step copies itsbundle-pathfile todist/nodkey_<version>.sigstore.json.v<version>. The version names the bundle file, and nobody can change a published release.env:.docs/releasing.md:VERSIONandARCHvariables, shows acurldownload with no login, and shows the--bundlecheck. It also says to use gh 2.93.0 or newer. No command line ends in a#comment: interactive zsh does not treat it as a comment by default.nodkey versionon the machine the binary is for.DESIGN.mdsection 18 has one sentence on the bundle file.Review
The security review found nothing high or medium. These points are fixed:
gh release downloadneeds a login only in gh older than 2.96.0. The docs said it always does.nodkey_9.9.9_linux_amd64.tar.gzfails it.TAGmatchesVERSION.gh --versionin the log.The reviewer tested the check with gh 2.96.0 and no login. Both 0.1.0 tarballs passed. These all failed: an empty file,
{}, a cut bundle, two bundles in one file, a release attestation, the wrong file and a missing bundle.The last box of #87 (a real release has the file, and the check passes with no login) gets ticked after the next release, so this pull request does not close the issue.
Part of #87.