Repository navigation
fix(frontend): Starter learners who removed their language can restore it from first run (D-07, D-20, D-25) - #141
Merged
Merged
Conversation
…e it from first run (D-07, D-20, D-25) On Starter a removed language holds its place for 30 days (server #138), so adding another language returns upgrade_needed. The client now knows this: - The store counts the held place (heldSlots) and exposes canRestore and restorable. - Add a language, first run included, shows the upgrade card with "Restore German" (kept until the purge date) and See plans; an unexpected upgrade_needed also shows the card instead of looping on step 1. "Back to Today" is hidden in first run. - The plans page is open during first run, so See plans no longer bounces back. - The chat test sends upgrade_needed back to the steps, keeping first run. - Languages offers "Add it back" whenever there is a free active place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.3.0-dev.32 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #139, for the server change in #138: on Starter a removed language keeps its place for 30 days, so a Starter learner who removes their only language lands on first run, and adding any other language returns
upgrade_needed. Before this PR the learner was stuck: first run hid the limit card, the add failed, and "See plans" bounced back to first run.heldSlots(Starter only, removed and beforepurgeAt),canAddcounts it, newcanRestoreandrestorable.upgrade_neededalso shows the card instead of looping on step 1. "Back to Today" is hidden in first run, since Today sends the learner back./settings/subscriptionis allowed, so See plans works.upgrade_neededreturns to the steps and keeps first run.Item 5 of #139 already reads
interestsand theenabled: falsePortuguese row; #138's shapes match.How it was tested
upgrade_neededanswer in first run shows the card; Languages "Add it back" on Starter.🤖 Generated with Claude Code