Repository navigation
feat(languages): send the learning language to analytics and show the own language in page settings (E-13, E-03) - #55
Merged
Merged
Conversation
… own language in page settings (E-13, E-03) - Analytics tests for learning_language and target_language from the server profile (the local guess no longer overwrites it). - The in-page Settings own-language select is labelled "Your own language" (it was "Interface Language") and, with language profiles, shows the server's value instead of a select that no longer applies. - CLAUDE.md: how the round-1 language code is laid out, and the new tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.17.0-dev.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The last small slice of the multilingual round in the extension.
learning_languageis registered next totarget_language.target_languagenow comes from the server profile once it has one, and the local value (a browser guess or an old pick) no longer overwrites it. This is the fix for the 643 of 802 users with notarget_language.phrase_savedandpractice-now_startedcarry the language. New events:language_switched,language_add_opened,save_language_changed,save_language_missing_choice,phrase_kept_pending,save_language_undo.Rows
E-13, and the last part of E-03 (the old own-language select).
How it was tested
tests/language-analytics.test.ts.yarn test(348 passing),yarn typecheck,yarn build.🤖 Generated with Claude Code