Repository navigation
fix(languages): send the user's id with the language calls so the pill and save row work (E-03, E-05) - #56
Merged
Merged
Conversation
…l and save row work (E-03, E-05) The server's user_access functions read the account from args.userId and answer "User ID is required" without it. get-language-state, set-active-language and keep-phrase-pending sent no userId, so against a real server the popup pill, the language list and the save window language row never showed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.17.0-dev.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The multilingual popup pill, the language list and the save window language row never showed against a real server.
The server's
user_accessfunctions read the account fromargs.userId(modular-rest does not add it; the server's caller guard only checks that it is yours).get-language-state,set-active-languageandkeep-phrase-pendingsent nouserId, so the server answered400 User ID is required. The client then treats the language module as missing and falls back to the English-only popup, without any error. The unit tests mock the server, so they did not catch it.Now each of those calls sends the signed-in user's id (
get-language-capabilitiesstays anonymous).Rows: E-03, E-05 (and E-06 / E-07, which use the same calls).
How it was tested
tests/language-api.test.tschecks the args of every language call; the whole Vitest suite passes (352), typecheck clean,yarn buildand the Playwright e2e suite pass (22).translateWithContextstubbed), in a Chromium profile with a local test account:get-language-state→ 400User ID is required;🤖 Generated with Claude Code