Repository navigation
fix(save): keep the save window open on the saved state, quiet tab messages (E-05, E-06, E-03) - #57
Merged
Merged
Conversation
…E-06)
The bundle list closes itself with a fake Escape key on its trigger
(pilotui's Select has no close method). The window's own Esc handler
listens on window in the capture phase, so it read that fake key as
"close the window". After "Save to German" (closeDropdown runs after a
save) and on any click inside the window while the list was open, the
whole window closed. Our own Escape is now marked and let through, and
a real Esc with the list open closes only the list.
A normal save now shows the saved state of design X6 ("Saved to Dark S1
· German", Back to my video, Practise it now, no Undo) in place of the
form. Without language profiles nothing changes.
"Save to English" for a language not added, when no bundle is ready,
shows the picker; the Save that follows is still that choice, so the
result keeps Undo back to the two choices (X8).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… (E-03) After a language switch the popup tells every open tab. A tab without our content scripts rejects with "Receiving end does not exist", which showed up as an uncaught error in the popup. That one error is now ignored; any other error is logged as a warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.17.0-dev.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes from the end-to-end run of multilingual round 1.
windowin the capture phase, so it read that fake key as "close the window".closeDropdown()runs after every save and on every outside click of the list, so both closed the window.dispatchInternalEscapeinescape.ts) and the window lets it through. A real Esc with the list open now closes only the list. The window closes only on X, Back to my video, Esc, or a click outside the window.Rows
E-05, E-06, E-03.
How it was tested
yarn test(358 passed, new tests inconsole-escape.test.ts,save-language.test.ts,tab-broadcast.test.ts),yarn typecheckclean,yarn build,yarn test:e2e(22 passed).translateWithContextstubbed, no AI key locally). Passed: popup switch with no errors; inside click and Esc with the list open close only the list; X6 saved state, and the window stays open; Back to my video closes it; X5 Change to English saves to an English bundle and the active language stays; X4 and X8 "Save to English" both ways (saved at once, and through the picker), and Undo goes back to the two choices. The same script on the old build fails on the popup errors and on the inside click.🤖 Generated with Claude Code