Skip to content

fix(search): honor UTC+0 timezone offset instead of collapsing to default -7 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylermenezes merged 1 commit into from
Sep 18, 2026
Merged

fix(search): honor UTC+0 timezone offset instead of collapsing to default -7 #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/search/ElasticEntry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ type ProjectInput = Project & { mentors: Mentor[], tags: Tag[], projectPreferenc
function getTimezoneOffset(timezoneString?: string) {
if (!timezoneString) return -7;
const basicLookup = getTimezoneOffsetInner(timezoneString);
if (basicLookup) return basicLookup;
if (basicLookup !== null) return basicLookup;
return {
'America - Pacific': -7,
'America - Mountain': -6,
Expand All @@ -119,7 +119,7 @@ function getTimezoneOffset(timezoneString?: string) {
SGT: 8,
Singapore: 8,
'APAC - Singapore': 8,
}[timezoneString || ''] || -7;
}[timezoneString || ''] ?? -7;
}

export function projectToElasticEntry({
Expand Down
2 changes: 1 addition & 1 deletion src/search/getProjectMatches.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function isStudentUnderrepresented(student: Student): boolean {

async function getTimezone(student: Student): Promise<number> {
if (student.timezone) {
return getTimezoneOffset(student.timezone) || -7;
return getTimezoneOffset(student.timezone) ?? -7;
}

const profile = <
Expand Down
Loading
Loading