Repository navigation
Conversation
35C4n0r
self-requested a review
August 25, 2026 17:14
35C4n0r
requested changes
Aug 26, 2026
35C4n0r
left a comment
35C4n0r
left a comment
Collaborator
There was a problem hiding this comment.
@v-atsai adding a signing key should be an additional feature in the module, we don't want to replace the current behaviour of the module from adding authentication SSH key to signing SSH key.
I'd suggest to add a new optional variable where users can key_type auth(default)/signing/both, this would add signing as an additive option rather than a replacement.
4 of 9 tasks
Edd88-pixel
pushed a commit
that referenced
this pull request
Oct 21, 2026
…ing keys (#1193) ## Description Adds an optional `key_type` variable to `github-upload-public-key` so the Coder public key can also be uploaded as a GitHub SSH signing key, letting GitHub verify commits signed with it. - `auth` (default): uploads to `/user/keys`, same as before. - `signing`: uploads to `/user/ssh_signing_keys`. - `both`: uploads to both, checking each endpoint independently so an existing key on one does not skip the other. Supersedes #1072 (thanks @v-atsai), keeping signing as an additive option instead of replacing authentication key upload. ## Type of Change - [ ] New module - [ ] New template - [ ] Bug fix - [x] Feature/enhancement - [ ] Documentation - [ ] Other ## Module Information **Path:** `registry/coder/modules/github-upload-public-key` **New version:** `v1.2.0` **Breaking change:** [ ] Yes [x] No ## Testing & Validation - [x] Tests pass (`bun test`): 9/9, including new `signing` and `both` cases; `terraform test`: 4/4 (new `main.tftest.hcl`) - [x] Code formatted (`bun fmt`) - [x] Changes tested locally against real GitHub ## Related Issues Supersedes #1072 <details> <summary>Decision log</summary> - **Additive, not a replacement.** Per review on #1072, `key_type` defaults to `auth` so existing templates keep uploading an authentication key. - **Single `upload_key` function.** Both endpoints share the same list/compare/POST flow, so `run.sh` runs it once per selected type and fails the script if either upload fails. - **Log wording.** Messages now name the key type (for example, "added as a GitHub signing key"). This changes the wording on the default path too; no exit-code changes. - **Required permissions, checked against GitHub docs.** Listing signing keys needs `read:ssh_signing_key` and creating needs `write:ssh_signing_key`; the README recommends `admin:ssh_signing_key`, matching the existing `admin:public_key` guidance. GitHub Apps need the "SSH signing keys" user permission (read for `GET`, write for `POST`). - **Out of scope.** The module only uploads the key; configuring Git in the workspace to sign commits with it is left to the template. - **Version.** Minor bump to `1.2.0` (new optional input). </details> --- > [!NOTE] > This PR was generated by Coder Agents on behalf of @35C4n0r, using Claude.
Collaborator
|
Closing in favour of #1193 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Module Information
Path:
registry/coder/modules/github-upload-public-keyNew version:
v1.1.1Breaking change:
Testing & Validation
bun test)bun fmt)Related Issues