Skip to content

Add a blank line after generated <summary> tag #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Oaphi merged 5 commits into from
Aug 28, 2026
Merged

Add a blank line after generated <summary> tag #2148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4588ecd
Add a blank line after generated <summary> tag
MoshiKoi Aug 23, 2026
1a7abed
Add hint text to explain the need for a blank line
MoshiKoi Aug 27, 2026
a25082a
Fix selection offset bug
MoshiKoi Aug 28, 2026
c8f9225
Edit title of miscellaneous tools dropdown to "Other tools"
MoshiKoi Aug 28, 2026
de26304
Simplify help comment
MoshiKoi Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/assets/javascripts/markdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ $(() => {
const preSelectionEnd = $field[0].selectionEnd;
QPixel.MD.insertIntoField($field, this.start, this.end);
$field[0].selectionStart = preSelectionStart + this.start.length;
$field[0].selectionEnd = preSelectionEnd + this.end.length;
$field[0].selectionEnd = preSelectionEnd + this.start.length;
}
}

Expand Down Expand Up @@ -102,7 +102,10 @@ $(() => {
hr: new InlineAction('\n\n-----\n\n'),
table: new InlineAction('\n\n| Title1 | Title2 |\n|- | - |\n| row1_1 | row1_2 |\n\n'),
mathjax: new InlineAction('$', '$'),
spoiler: new InlineAction('\n\n<details>\n<summary>Spoiler</summary>\n', '\n</details>\n\n'),
spoiler: new InlineAction(
'\n\n<details>\n<summary>Spoiler</summary>\n' +
'<!-- An empty line is required for markdown to render -->\n\n',
'\n</details>\n\n'),
};

$(document).on('click', '.js-markdown-tool', (ev) => {
Expand Down
2 changes: 1 addition & 1 deletion app/views/shared/_markdown_tools.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@

<div class="button-list is-gutterless">
<a href="javascript:void(0)" class="button is-outlined is-muted is-icon-only" data-drop="#markdown-tools"
data-drop-self-class-toggle="is-active" aria-label="Tools" title="Tools: headings, lines" role="button">
data-drop-self-class-toggle="is-active" aria-label="Tools" title="Other tools" role="button">
<i class="fas fa-tools"></i>
</a>

Expand Down
Loading