fix(flaunch): exact Permit2 amountIn and short deadline - #1412
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
Permit2 AllowanceTransfer on sellCoin used maxUint160 with a ~10-year expiration/sigDeadline whenever allowance was low. Permit only this sell's amountIn for 30 minutes so leftover UniversalRouter rights cannot linger. Sibling hygiene to CDP exact Permit2 (coinbase#1409); distinct provider.
🟡 Heimdall Review Status
|
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaunch sellCoin was signing a Permit2 AllowanceTransfer for
maxUint160with a ~10-year expiration and sigDeadline whenever the current allowance was too low. That leaves the UniversalRouter with unbounded, long-lived rights to the memecoin after (or instead of) the intended sell.This permits only the sell
amountInfor 30 minutes. Same over-approval hygiene as the CDP exact Permit2 path in #1409, different provider and Permit2 surface (local typed data on Flaunch, not ERC-20 approve to Permit2). Sibling of #1409/#1410/#1411. Does not reopen those PRs' findings.Test plan
pnpm exec jest --testPathPattern='flaunch/flaunchActionProvider' --coverage=false(20/20)amountInand is notmaxUint160signTypedDataMade with Cursor