fix(flaunch): fail closed on unsafe token image URLs and paths - #1424
Closed
SashaMIT wants to merge 1 commit into
Closed
fix(flaunch): fail closed on unsafe token image URLs and paths#1424SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Agent-controlled image input used bare fetch (SSRF) or fs.readFile (arbitrary local read) before IPFS upload. Require https with a non-blocked host (no redirects), and confine local paths to cwd.
🟡 Heimdall Review Status
|
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flaunch token creation takes an agent-controlled
imagestring and eitherfetches it orfs.readFiles it before uploading bytes to IPFS. There was no host allowlist, redirect policy, or cwd confinement, so a tool call could hit loopback/metadata (SSRF) or read arbitrary local files.This PR:
https://with a non-blocked host (loopback / RFC1918 / link-local / CGNAT /.localhost)fetch(..., { redirect: "error" })so redirects cannot bypass the host checkprocess.cwd()viarealpathDistinct from open #1421 / #1423 (quote fail-closed).
Test plan
npx jest --testPathPattern=metadata_utils(5 passed)http://127.0.0.1/...and/etc/passwdfail closedMade with Cursor