Improve storage pre-check recovery guidance - #233
Open
nelsonjchen wants to merge 1 commit into
Open
nelsonjchen wants to merge 1 commit into
nelsonjchen wants to merge 1 commit into
Conversation
nelsonjchen
force-pushed
the
codex/storage-guidance
branch
from
September 15, 2026 04:37
7f883d9 to
f6a9ee6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can try the updated flow at https://comma-flash.mindflakes.com/
Summary
Browsers can report enough available storage while still failing when a large flash image is written to persistent site storage. This adds a storage reservation check as the first step in the existing flashing flow, before device selection.
When the check fails, the UI gives focused recovery guidance:
chrome://settings/content/siteData, including settings that delete data when the browser closes.The existing skip action remains available. Holding Shift while clicking Skip storage check exposes the failure UI for testing.
Screenshot
Background
The relevance of the persistent site-data setting was raised in this Discord discussion.
Verification
pnpm exec vitest run src/utils/image.test.js src/app/App.test.jsxpnpm run build