chore(deps): bump uuid from 11 to 14#457
Closed
joaquimds wants to merge 1 commit into
Closed
Conversation
Three majors, but the only API used across the codebase is the
`import { v4 as uuidv4 } from "uuid"` named export, which is unchanged
throughout.
The breaking changes and why they are safe here:
- v12 removes CommonJS support. Both tsconfigs are module esnext with
moduleResolution bundler, there is no require("uuid") anywhere, and the
published SDK (tsconfig.api.json) does not use uuid.
- v13 makes browser exports the default, which relies on a global crypto.
- v14 requires node@20+ for that global crypto. CI runs node 22 on all
three workflows and local development is on node 22.
Verified with npm run lint, npm run build and the full unit suite (285
passed), which covers the tRPC routers and the webhook refresh job where
uuidv4 is used.
Stacked on top of the Dependabot batch (#455).
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three major versions in one jump, but the only API this codebase uses is the
import { v4 as uuidv4 } from "uuid"named export — unchanged across all three — in 28 files across the map UI, tRPC routers, jobs and tests.The breaking changes, and why each is safe here
module: esnext/moduleResolution: bundler. Norequire("uuid")anywhere insrc,bin,testsormigrations. The published SDK (tsconfig.api.json) doesn't use uuid.crypto, which Node 20+ provides.cryptonode-version: 22; local dev is on 22.The CommonJS removal was the one worth actually checking rather than assuming — it's the change most likely to break a mixed-module codebase at runtime rather than at build time.
Verification
npm run lint(prettier, eslint,tsc --noEmit, madge) — cleannpm run build— succeedsnpm test -- run tests/unit— 285 passed, 15 skipped, covering the tRPC routers andrefreshWebhookswhereuuidv4is calledRemaining uuid findings after this
npm auditstill reports a moderateuuidadvisory, but from nested copies under@sanity/uuid(8.3.2) andtypeid-js— not our direct dependency. Those need a sanity-side bump.Note
Stacked on #455 — the base will retarget to
mainautomatically once that merges.🤖 Generated with Claude Code