Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JvEmz7CHxsyLEmhWwPWm7F
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JvEmz7CHxsyLEmhWwPWm7F
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JvEmz7CHxsyLEmhWwPWm7F
…nitenessTest Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JvEmz7CHxsyLEmhWwPWm7F
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JvEmz7CHxsyLEmhWwPWm7F
…, align IOException sibling
MetadataResource.save can throw PAYMENT_REQUIRED (402) after registerWorkflowDef already
committed the write, so definiteFor(402) was wrongly telling callers a retry was safe.
ApiException#toString() never printed the definite flag, so log readers still had no way
to tell a logged failure's definiteness, which was the core ask behind this flag. The
print is placed outside the status>0 guard so it still shows for the Jepsen status==0 case.
checkAndUploadToExternalStorage's local JSON-serialization failure is a pre-transmission
error like its payload-threshold sibling, so it now gets the same setDefinite(true).
Also fixes a broken {@link #isRetryable()} javadoc reference (Lombok-generated, unresolvable).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JvEmz7CHxsyLEmhWwPWm7F
…ers cleanly at status==0
The prior change appended ", definite: ..." unconditionally after a brace that was only
opened inside the status>0 guard, so the status==0 case (the Jepsen case this flag exists
for) rendered a stray leading comma with no opening brace. Open " {" unconditionally and
move the separator inside the guard instead, so status>0 renders byte-identical to before
and status==0 now renders " {definite: false}".
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JvEmz7CHxsyLEmhWwPWm7F
mp-orkes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Withdrawn, I'll open another PR after considering alternatives to
error.isDefinite()