Skip to content

meson: fix deprecation warnings - #653

Closed
acsezen wants to merge 1 commit into
containers:mainfrom
acsezen:chore/meson-cleanups
Closed

meson: fix deprecation warnings#653
acsezen wants to merge 1 commit into
containers:mainfrom
acsezen:chore/meson-cleanups

Conversation

@acsezen

@acsezen acsezen commented Apr 3, 2026

Copy link
Copy Markdown

Summary

  • add explicit check arguments to run_command() calls
  • replace deprecated meson.source_root() with meson.project_source_root()
  • raise the declared minimum Meson version to 0.56 to match the APIs already in use

Testing

  • meson setup build-pr-check .

@jnovy

jnovy commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator

@acsezen Thanks for this PR - would you mind to sign-off your commit?

@kolyshkin

Copy link
Copy Markdown
Collaborator

@acsezen can you please rebase (git pull --rebase origin main) and sign-off (git commit --amend -s) this commit?

@kolyshkin
kolyshkin force-pushed the chore/meson-cleanups branch from 6e43e5e to 1842231 Compare August 13, 2026 22:45
@packit-as-a-service

Copy link
Copy Markdown

Ephemeral COPR build failed. @containers/packit-build please check.

@kolyshkin

Copy link
Copy Markdown
Collaborator

Nothing here (on GH CI) uses meson, so I tested this locally by building via meson. It works fine and removes a few meson warnings that were present before.

@acsezen can you please rebase (git pull --rebase origin main) and sign-off (git commit --amend -s) this commit?

Nevermind, let me carry this in #670

@kolyshkin kolyshkin closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants