seccomp: fix inverted notify socket setup logic - #656
Merged
Conversation
In 3a8c913, the conditional in src/conmon.c was inadvertently reversed when the syntax was changed. Signed-off-by: Caleb Xu <caxu@redhat.com>
Collaborator
|
@kolyshkin re-enabling the seccomp logic (which is broken and never used in conmon) introduces a lot of regressions. @giuseppe FYI - assuming we should keep this disabled? |
Member
|
Yes, we haven't yet found a way to deal with seccomp notifications in conmon |
Collaborator
Are you saying this patch should be reverted? Or that we should never enable seccomp notifications (perhaps by removing the code entirely)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 3a8c913, the conditional in src/conmon.c was inadvertently reversed when the syntax was changed.
3a8c913#diff-737dc81597d3e3189077545b4907aae69cce646d12b5bc5938cfdd707882bd31R181