Skip to content

seccomp: fix inverted notify socket setup logic - #656

Merged
kolyshkin merged 1 commit into
containers:mainfrom
caxu-rh:seccomp-notify-socket-ifdef
Aug 13, 2026
Merged

seccomp: fix inverted notify socket setup logic#656
kolyshkin merged 1 commit into
containers:mainfrom
caxu-rh:seccomp-notify-socket-ifdef

Conversation

@caxu-rh

@caxu-rh caxu-rh commented May 15, 2026

Copy link
Copy Markdown
Contributor

In 3a8c913, the conditional in src/conmon.c was inadvertently reversed when the syntax was changed.

3a8c913#diff-737dc81597d3e3189077545b4907aae69cce646d12b5bc5938cfdd707882bd31R181

diff --git a/src/conmon.c b/src/conmon.c
index 795701c68f754cee5d22422e12872ca24748472a..7dd1f0b560c0e593dc289f42e35931554dcb7fd9 100644
--- a/src/conmon.c
+++ b/src/conmon.c
@@ -178,7 +178,7 @@ int main(int argc, char *argv[])
 	}
 
 	if (opt_seccomp_notify_socket != NULL) {
-#if !USE_SECCOMP
+#ifdef USE_SECCOMP
 		pexit("seccomp support not present");
 #else
 		if (opt_seccomp_notify_plugins == NULL)

In 3a8c913, the conditional in
src/conmon.c was inadvertently reversed when the syntax was
changed.

Signed-off-by: Caleb Xu <caxu@redhat.com>

@kolyshkin kolyshkin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin
kolyshkin merged commit ad843e6 into containers:main Aug 13, 2026
18 checks passed
@jnovy

jnovy commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

@kolyshkin re-enabling the seccomp logic (which is broken and never used in conmon) introduces a lot of regressions. @giuseppe FYI - assuming we should keep this disabled?

@giuseppe

Copy link
Copy Markdown
Member

Yes, we haven't yet found a way to deal with seccomp notifications in conmon

@kolyshkin

Copy link
Copy Markdown
Collaborator

@kolyshkin re-enabling the seccomp logic (which is broken and never used in conmon) introduces a lot of regressions.

Are you saying this patch should be reverted? Or that we should never enable seccomp notifications (perhaps by removing the code entirely)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants