sysfs: return untyped nil for hardware which is not there. - #778
Merged
Conversation
klihub
force-pushed
the
fixes/sysfs/return-untyped-nil
branch
from
September 10, 2026 10:45
2c8d91d to
972877f
Compare
System.CPU, System.Node and System.Package returned a nil pointer inside a non-nil interface for an id the machine does not have. Such a value is never == nil, so callers' nil checks were dead code and the call after them would have panicked. Return an untyped nil instead, and stop dereferencing without checking in SingleThreadForCPUs and NodeDistance. Assisted-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
fixes/sysfs/return-untyped-nil
branch
from
September 10, 2026 10:51
972877f to
43e9412
Compare
askervin
approved these changes
Sep 11, 2026
askervin
left a comment
askervin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Yet "already"s in below comments in unit tests were sort of helpful for reviewing this particular PR, they'll be less so after merging this code. So as a super-nit, I'd be fine dropping them.
// Node.DistanceFrom already returns for an unknown destination.
...
// an absent destination was already handled, and still is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.CPU, System.Node and System.Package returned a nil pointer inside a non-nil interface for an id the machine does not have. Such a value is never == nil, so callers' nil checks were dead code and the call after them panicked. Return an untyped nil instead, and stop dereferencing without checking in SingleThreadForCPUs and NodeDistance.