Conversation
systemd does not perform shell-style tilde expansion, so a host path starting with `~/` left in a generated Quadlet file is passed to Podman as an invalid relative path and the service fails to start. Replace the leading `~` with the systemd `%h` specifier instead. Also fix the systemd specifier check in `absolute_clean_path()`, which used `Path::starts_with()` and therefore only matched a path whose first component was exactly `%`, causing `--absolute-host-paths` to prepend the resolve directory to paths such as `%h/data`. Closes: containers#166 Signed-off-by: DualFroz <me@dualfroz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
systemd does not expand
~, soVolume=~/data:/datafrompodlet generategave Podman a relative path and the service failed, and a leading~now becomes%h.This also fixes
absolute_clean_path(), which compared path components and so never treated%h/dataas absolute.Closes #166