Skip to content

feat(taxonomy): remove locale param from fetch(), bump to v5.4.0#379

Merged
cs-raj merged 1 commit into
mainfrom
feat/taxonomy-publishing-v5.4.0
Jul 16, 2026
Merged

feat(taxonomy): remove locale param from fetch(), bump to v5.4.0#379
cs-raj merged 1 commit into
mainfrom
feat/taxonomy-publishing-v5.4.0

Conversation

@cs-raj

@cs-raj cs-raj commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removed locale? param from Taxonomy.fetch() and Term.fetch() — the parameter was an inconsistency with how the rest of the SDK handles query modifiers. Locale (and any other query param) should be set via the chainable .param() / .addParams() API before calling .fetch().
  • Version bump: 5.3.05.4.0 (minor — new API surface for taxonomy publishing, behavioral change on fetch() signature).
  • Regenerated package-lock.json.

Breaking Change

fetch(locale?) on Taxonomy and Term no longer accepts a locale argument.

Before:

stack.taxonomy('gadgets').fetch('fr-fr')
stack.taxonomy('gadgets').term('smartphone').fetch('fr-fr')

After:

stack.taxonomy('gadgets').param('locale', 'fr-fr').fetch()
stack.taxonomy('gadgets').term('smartphone').param('locale', 'fr-fr').fetch()

Callers that did not pass locale to fetch() are unaffected.


Files Changed

File Change
src/taxonomy/index.ts Removed locale? param from fetch(), updated JSDoc example
src/taxonomy/term.ts Same as above for Term.fetch()
test/unit/taxonomy.spec.ts Updated locale test to use .param('locale', ...).fetch()
test/unit/term.spec.ts Same
test/api/taxonomy.spec.ts All locale calls updated; gadgets en-us/fr-fr tests added
test/api/term.spec.ts All locale calls updated; gadgets smartphone fr-fr tests added
CHANGELOG.md Added v5.4.0 entry
package.json Version → 5.4.0
package-lock.json Regenerated

Test Coverage

  • 31 unit tests pass (taxonomy, term, taxonomy-query, term-query)
  • 57 API tests pass (taxonomy, term, term-query + gadgets-specific suites)

Checklist

  • Taxonomy.fetch() signature updated
  • Term.fetch() signature updated
  • JSDoc examples updated in both classes
  • All unit tests updated to .param('locale', ...).fetch()
  • All API tests updated to .param('locale', ...).fetch()
  • Gadgets-specific API tests added (en-us, fr-fr, locales, ancestors, descendants)
  • CHANGELOG entry added for v5.4.0
  • package.json version bumped to 5.4.0
  • package-lock.json regenerated

@cs-raj
cs-raj requested a review from a team as a code owner July 16, 2026 07:25
@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@github-actions

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
98.76% (-0.01% 🔻)
958/970
🟢 Branches
95.95% (-0.03% 🔻)
284/296
🟢 Functions 97.76% 218/223
🟢 Lines
99.24% (-0% 🔻)
910/917
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 taxonomy/index.ts
91.3% (-0.7% 🔻)
100% 85.71%
90.48% (-0.43% 🔻)
🟢 taxonomy/term.ts
90.91% (-0.52% 🔻)
25% (-15% 🔻)
100% 100%

Test suite run success

698 tests passing in 35 suites.

Report generated by 🧪jest coverage report action from 34113cc

@cs-raj
cs-raj merged commit 6fcb900 into main Jul 16, 2026
10 checks passed
@cs-raj
cs-raj deleted the feat/taxonomy-publishing-v5.4.0 branch July 16, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants