Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text lengths and other values displayed in the Type column were missing from advanced data-type searches, and matching table descriptions were not highlighted. Search the displayed type details, including formatted and raw numbers, and highlight matching lengths, ranges, precision, file sizes, choice values/descriptions, lookup targets, and table descriptions while respecting the selected scope.
Depends on #99. This branch includes its shared search matcher; merge #99 first, then review and merge this follow-up. The branch also includes current main.
Validation: focused matcher/worker/highlight checks across all ten column types; synthetic browser checks for text length, TimeZoneIndependent, table descriptions, and scope exclusion; website lint and full production build/postbuild passed. Existing repository warnings remain. Screenshots were reviewed locally using synthetic sample data.
A separate search-initialization timing issue was observed when opening a prefilled search URL before metadata loads; the browser checks here exercise typing after metadata is ready.