feat(pure-cell): экспортировать типы пропсов [DS-14525] - #2279
musique-128 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: a14f765 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
coverage: 82.172% (+0.004%) from 82.168% — feat/DS-14525 into master |
Demo build (default) |
Demo build (alfasans) |
Co-authored-by: fulcanellee <45999900+fulcanellee@users.noreply.github.com>
| import styles from './index.module.css'; | ||
|
|
||
| type Props = { | ||
| export type PureCellAddonProps = { |
There was a problem hiding this comment.
у нас по кодстайлу принято изменять все паблик апи на interface, если уж пошла такая песня :D отдай наружу interface пожалуйста
fulcanellee
left a comment
fulcanellee
left a comment
There was a problem hiding this comment.
Извиняемся что PR завалялся. Если еще актуален, то внеси правки и вольём
| onClick?: () => void; | ||
| }; | ||
|
|
||
| export type Props = PureCellGraphicsProps; |
There was a problem hiding this comment.
кажется эта строчка лишняя
| export type { PureCellAmountTitleProps } from './components/amount-title'; | ||
| export type { PureCellAddonProps } from './components/addon'; | ||
| export type { PureCellFooterProps } from './components/footer'; | ||
| export type { FooterTextProps as PureCellExtraSubtitleProps } from './components/footer-text'; |
There was a problem hiding this comment.
FooterTextProps as PureCellFooterTextProps не подойтет?
| export type { PureCellFooterProps } from './components/footer'; | ||
| export type { FooterTextProps as PureCellExtraSubtitleProps } from './components/footer-text'; | ||
| export type { PureCellFooterButtonProps } from './components/footer-button'; | ||
| export type { CommentProps as PureCellCommentProps } from '@alfalab/core-components-comment'; |
There was a problem hiding this comment.
это взято из друго пакета. нужно убрать @alfalab/core-components-comment
This branch has not been deployed
5 participants
Добавлены публичные экспорты типов пропсов компонента PureCell и его составных частей с сохранением обратной совместимости существующих импортов. Обновлена документация.
Чек лист