Skip to content

feat(tab-bar-island): glass-like view - #2345

Open
hextion wants to merge 5 commits into
masterfrom
feat/tab-bar-island-glass
Open

feat(tab-bar-island): glass-like view#2345
hextion wants to merge 5 commits into
masterfrom
feat/tab-bar-island-glass

Conversation

@hextion

@hextion hextion commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@changeset-bot

changeset-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fab3241

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-tab-bar-island Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls

coveralls commented Sep 4, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 82.364%. remained the same — feat/tab-bar-island-glass into master

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Demo build (default)

https://core-ds.github.io/core-components/2345

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Demo build (alfasans)

https://core-ds.github.io/core-components/2345-alfasans

.label {
@mixin action_secondary_small;

position: relative;

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to get correct z-index

@hextion
hextion force-pushed the feat/tab-bar-island-glass branch from 04eac73 to 5b467fa Compare September 9, 2026 09:16
@hextion
hextion marked this pull request as ready for review September 9, 2026 10:07
height: 100%;
width: 100%;
background: var(--color-light-neutral-translucent-200);
background: var(--tab-bar-island-tab-tracker-backround-color);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backround → background

@SiebenSieben

Copy link
Copy Markdown
Contributor

Заметил, что у трейлинг таба есть underlay, и он по z-index выше самой кнопки, проверь пжлст

@SiebenSieben

SiebenSieben commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Стекло сломало тёмный режим

image

@SiebenSieben
SiebenSieben requested a review from Oladii September 10, 2026 08:00
@hextion
hextion force-pushed the feat/tab-bar-island-glass branch from 5b467fa to e828332 Compare September 13, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants