Install latest Firefox and NVDA from official sources - #46
Open
AnsonShie wants to merge 11 commits into
Open
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
AnsonShie
marked this pull request as ready for review
August 6, 2026 16:22
AnsonShie
had a problem deploying
to
windows-a11y
August 6, 2026 16:23 — with
GitHub Actions
Failure
Log aggregate and per-update HRESULT diagnostics, and preserve failed SSM stdout and exit status in the AMI workflow. Co-authored-by: Codex <codex@openai.com>
AnsonShie
had a problem deploying
to
windows-a11y
August 7, 2026 16:14 — with
GitHub Actions
Failure
Replace the fixed AWS image waiter with observable state polling that tolerates eventual consistency and waits up to thirty minutes. Co-authored-by: Codex <codex@openai.com>
AnsonShie
had a problem deploying
to
windows-a11y
August 9, 2026 16:45 — with
GitHub Actions
Failure
AnsonShie
had a problem deploying
to
windows-a11y
August 9, 2026 16:52 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
VERSION_*outputs and update environment verification.InvalidAMIID.NotFoundeventual consistency.Why
Firefox and NVDA were installed through Chocolatey, so AMI builds depended on a third-party package feed and could lag official stable releases. Direct official downloads make the selected release source explicit and allow publisher-signature verification.
The latest NVDA release installs under
C:\Program Files\NVDA; the previous fixed x86 path caused version collection and AMI verification to miss a successful current installation.Windows Update failures previously exposed only aggregate result code 4. The workflow also captured SSM stdout but exited before printing it, hiding the update titles and HRESULT values needed for diagnosis.
The AWS CLI
image-availablewaiter checks 40 times at 15-second intervals. A successful historical AMI build already took 9 minutes 41 seconds, leaving almost no margin before that fixed limit. The latest build exceeded it and returned exit code 255 even though all installation and environment verification steps had passed.Impact
Each Windows accessibility AMI build now selects the publishers' current stable releases at build time. Beta, RC, ESR, Developer Edition, and Nightly builds are excluded. Failures resolving, downloading, validating, or installing the official artifacts stop the AMI build.
Windows Update remains fail-closed. On failure, the workflow reports aggregate and per-update diagnostics before returning the original nonzero status.
AMI creation can remain pending for up to about thirty minutes. Each poll is visible in the workflow log, actual failed states stop immediately with their StateReason, and the existing
ami_idoutput contract remains unchanged.Superpowers planning/specification artifacts are intentionally excluded from this PR.
Validation
git diff --checkpassedA live AMI build and real Windows installer execution have not been rerun after the AMI polling change.