We need to verify that doing the TACCalibration module (and TAC cuts) before/after the EnergyCalibration module yields the same results. Back in February, if the EnergyCalibration module was not required first and the nearest neighbors were being read out, the TAC cuts were failing for NN and direct hits. From Robin on February:
Preliminary tests don't see a difference when EnergyCalibration is required vs not before the TACCalibrationFrom module. From Nicole on September:
There are two remaining issues with assigning a definitive order of calibrations:
We need to verify that doing the
TACCalibrationmodule (and TAC cuts) before/after theEnergyCalibrationmodule yields the same results. Back in February, if theEnergyCalibrationmodule was not required first and the nearest neighbors were being read out, the TAC cuts were failing for NN and direct hits. From Robin on February:Preliminary tests don't see a difference when
EnergyCalibrationis required vs not before theTACCalibrationFrommodule. From Nicole on September:There are two remaining issues with assigning a definitive order of calibrations:
We want to be able to use the
TACCalibrationmodule (and respective TAC cuts) before theEnergyCalibrationmodule for Robin's energy calibrations. This points to usingAddPreceedingModuleType(MAssembly::c_TACCalibration)on theEnergyCalibrationmodule, BUT:Future students will need to only use the
TACCalibrationorEnergyCalibrationmodules uniquely for detector effects analysis, so assigning a requirement might over-complicate their work.