-
Notifications
You must be signed in to change notification settings - Fork 17
Implementing NN into Strip Pairing #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
ec76532
CHG: Speed optimizations
zoglauer fc91b21
Merge pull request #2 from zoglauer/feature/strip_pairing_speedup
julianmgerber fe0a54e
Merge remote-tracking branch 'upstream/develop/em'
d73b58b
Included option to save QA-flagged events
ckierans 1edeef3
Fixed missing lines after cherry pick
ckierans 87c75ae
Button layout
ckierans a1ab750
Merge remote-tracking branch 'upstream/develop/em'
6097e47
Merge remote-tracking branch 'upstream/develop/em'
2879859
Merge remote-tracking branch 'upstream/develop/em'
d96b0ec
Separate out NN and triggered strips when collecting strip pairing st…
633cf5d
commenting
a872494
function to collect NN strip hits
cc35e5e
Assign Nearest Neighbor function in strip pairing. Created new "addne…
14bce2e
bug fixes
6a721e8
adding variable to tell if nearest neighbors are included in strip hits
a9fb662
comment
e0c430e
Read out NN strip hits into .dat file
ae7d555
Changing how nearest neighbor is referenced
14330c2
Adding flag for ambiguous neighbors
83a0cc1
forgot to initialize new variable
b5243d3
Update variable/function names
25551a4
Edit MStripHit parse function to account for new .dat readout
9f7b813
Merge remote-tracking branch 'carolyn/qa_option'
dc40418
Revert "Merge remote-tracking branch 'carolyn/qa_option'"
1fd176a
Merge remote-tracking branch 'upstream/develop/em'
0dc4d82
Merge branch 'main' into StripPairingNN
293e36e
Fixing bugs from merge
8adf152
Editing error message in MStripHit Parse
29383fe
Merge remote-tracking branch 'upstream/develop/em'
6a78116
Merge remote-tracking branch 'upstream/develop/em'
5a30de1
Merge branch 'main' into StripPairingNN
a9ba3ea
commenting
81fa180
fix bug in GetNearestNeighborStripHit function
3f01a01
using 'include nn' tag from HDF loader module
78f621d
just iterating thru SH to check if there are neighbors
0a9c722
commenting
696fee1
change StripHits to TriggeredStripHits where relevant
15841ca
fix big in streamdat
cd5a457
Merge remote-tracking branch 'upstream/develop/em'
faabfaa
Merge branch 'main' into StripPairingNN
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering about any potential confusion/overlap with NN strip hits listed here vs in the StripHit list that then have the IsNearestNeightbor flag. Do we expect NN strip hits to also be listed in the standard GetStripHit list or is that now exclusively for triggered strips? If so, let's make that clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetStripHit from the MHit class should only be triggered strip hits. However, the GetStripHit function in MReadOutAssembly (for the whole event) would have both triggered and NN strips. I added some comments to clarify