CHG: Enclose all cout statements in g_Verbosity - #205
Conversation
| MParser Parser; | ||
| if (Parser.Open(m_DeadtimeFileName) == false) { | ||
| cout << m_Name << ": Unable to open deadtime parameters file: " << m_DeadtimeFileName << endl; | ||
| if (g_Verbosity >= c_Error) cout << m_Name << ": Unable to open deadtime parameters file: " << m_DeadtimeFileName << endl; |
There was a problem hiding this comment.
Should we add e.g. "ERROR in src/MSubModuleShieldTrigger:ParseDeadtimeFile: " for the DEE submodules without the XmlTags, like you have for MSubModuleShieldTrigger?
There was a problem hiding this comment.
I'm fine doing whatever for the DEE SubModules 😃
Should this be part of this PR or of a follow-up PR?
There was a problem hiding this comment.
Up to you, if you want to handle this in a follow-on PR, then I'd call this good to go once you rebase again.
There was a problem hiding this comment.
Let's move this to a follow-up PR
|
I also see that this needs to be rebased, now that #194 was merged and this affects some files. |
7f34590 to
750fefb
Compare
fhagemann
left a comment
There was a problem hiding this comment.
With the latest force-push, I am rebasing this onto the changes from #194 to enclose all cout statements in MModuleTACCalibration also in g_Verbosity.
See the two comments about using g_Warning, even though the error message says "Error"
| if (g_Verbosity >= c_Warning) cout<<m_XmlTag | ||
| <<": Error: DetID "<<DetID | ||
| <<" has no TAC calibration entries - skipping event" | ||
| <<endl; |
There was a problem hiding this comment.
This statement says Error, but it's being run for every MReadOutAssembly* Event and would spam the terminal output, that's why I chose c_Warning here.
| if (g_Verbosity >= c_Warning) cout<<m_XmlTag | ||
| <<": Error: Unable to identify Side "<<Side | ||
| <<" - skipping event" | ||
| <<endl; |
There was a problem hiding this comment.
This statement says Error, but it's being run for every MReadOutAssembly* Event and would spam the terminal output, that's why I chose c_Warning here.
750fefb to
c236639
Compare
|
I just rebased this. |
Some
coutstatements were not enclosed in anyg_Verbositylevel statement, which should be fixed with this PR.Or another side not: currently, when running with verbosity
c_Info, the terminal gets flooded with output, mostly from the energy calibration printing every ADC to keV conversion. We might want to make use of thec_Chattyorc_Extremeverbosity levels from megalib also here in nuclearizer by moving some extreme output (especially that printed for EVERY strip hit) toc_Chattyorc_Extreme: