ADD: Hardware threshold files from unit-level data - #208
Merged
fhagemann merged 2 commits intoSep 15, 2026
Merged
Conversation
Author
fhagemann
marked this pull request as ready for review
September 15, 2026 06:22
Author
ckierans
approved these changes
Sep 15, 2026
ckierans
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, @fhagemann !
resource/calibration/COSISMEX/unit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Needed by #190, addressing issue #195:
Based on the threshold finding app, @JarredMRoberts determined the hardware threshold files and uploaded them to Google Drive: https://drive.google.com/drive/folders/1FN4fp0_imv-opuJHoKn1N3DPwUUPe38A?usp=sharing
In this PR, we're adding the files for the individual flight detectors to
resource/calibration/COSISMEX/unit, and a combined file containing all 16 flight detectors toresource/calibration/COSISMEX/payload.I made some changes compared to the files that were on Google Drive:
STRIP_IDdetermined from the strip map to follow the format ofresource/dee/dummy_hardware_thresholds.csv(which follows the format also of the average fast/slow threshold files that we determine in unit-level testing)I'm opening as a draft for now, because I haven't tried running the code in #190 using these threshold files.
Will mark this as "ready for review" once I have tested this.