Skip to content

CHG: Only compile files used in nuclearizer - #212

Merged
zoglauer merged 1 commit into
cositools:develop/emfrom
zoglauer:feature/makefilefilter
Sep 22, 2026
Merged

zoglauer merged 1 commit into
cositools:develop/emfrom
zoglauer:feature/makefilefilter

Conversation

@zoglauer

Copy link
Copy Markdown
Collaborator

This is a small emergency fix to make nuclearizer work with the latest changes in MEGAlib

@zoglauer
zoglauer requested a review from fhagemann September 22, 2026 06:25
@fhagemann

Copy link
Copy Markdown

I can see my review was requested, but I don't think I'm the right person to make this call.
No idea what the implications are.. 😅

@fhagemann

Copy link
Copy Markdown

Is this to work with main or develop-cosi? Because I can see some recent changes on main that are not on develop-cosi (yet)..

@zoglauer

Copy link
Copy Markdown
Collaborator Author

And I forgot to push.
On the MEGAlib side, those are the changes for the new roa format. I added an example to MModuleSaver, which is not yet compatible with nuclearizer.
Since nuclearizer doesn't use that file, I excluded it from compilation, along with a few other files nuclearizer doesn't use.

@zoglauer

Copy link
Copy Markdown
Collaborator Author

There is literally no magic in this PR - don't compile files, which nuclearzier is not using.

@fhagemann fhagemann left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I tested this with the newest push onto develop-cosi:

Without this PR, the current develop/em fails to compile:

megalib/src/fretalon/framework/src/MModuleSaver.cxx: In member function ‘virtual bool MModuleSaver::AnalyzeEvent(MReadOutAssembly*)’:
megalib/src/fretalon/framework/src/MModuleSaver.cxx:171:33: error: cannot convert ‘MReadOutFileFormat’ to ‘bool’
  171 |     if (Event->StreamRoa(m_Out, m_RoaFileFormat) == false) {
      |                                 ^~~~~~~~~~~~~~~
      |                                 |
      |                                 MReadOutFileFormat

With this PR, it succeeds to compile 👍
(I did not run nuclearizer, just checked for compilation).

@zoglauer
zoglauer merged commit a892258 into cositools:develop/em Sep 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants