CHG: Only compile files used in nuclearizer - #212
Conversation
|
I can see my review was requested, but I don't think I'm the right person to make this call. |
|
Is this to work with |
|
And I forgot to push. |
|
There is literally no magic in this PR - don't compile files, which nuclearzier is not using. |
fhagemann
left a comment
There was a problem hiding this comment.
Ok, so I tested this with the newest push onto develop-cosi:
Without this PR, the current develop/em fails to compile:
megalib/src/fretalon/framework/src/MModuleSaver.cxx: In member function ‘virtual bool MModuleSaver::AnalyzeEvent(MReadOutAssembly*)’:
megalib/src/fretalon/framework/src/MModuleSaver.cxx:171:33: error: cannot convert ‘MReadOutFileFormat’ to ‘bool’
171 | if (Event->StreamRoa(m_Out, m_RoaFileFormat) == false) {
| ^~~~~~~~~~~~~~~
| |
| MReadOutFileFormat
With this PR, it succeeds to compile 👍
(I did not run nuclearizer, just checked for compilation).
This is a small emergency fix to make nuclearizer work with the latest changes in MEGAlib