FIX: Guard ring contact handling when loading 4-column strip map files - #217
Merged
Merged
Conversation
Author
|
To test this, we could create a 4-column strip map file from a 9-column strip map files (just keeping the first and the last three columns), and check that if we generate a strip map from the "full" 9-column strip map file and the "compact" 4-column strip map file, the stored |
fhagemann
force-pushed
the
fix/strip_map
branch
from
September 24, 2026 02:17
fd4ecf2 to
24770eb
Compare
Collaborator
|
Well, I saw what you wrote before, guess we see if it works when we have the real data? |
zoglauer
approved these changes
Sep 24, 2026
Author
|
I tested this on a file containing only pulser data, but with 4 active detectors. Now with the changes in this PR, I don't get the error anymore and the results look reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216:
For strip map files with only 4 columns, we infer information about
RTB,DRM,IsPrimary,ASICIDandChannelfrom theReadOutID. The way we were doing that so far was wrong for guard ring contacts, and also theRTBandDRMvalues were wrong for all strip contacts.This PR contains two fixes:
RTBandDRMwhen loading a 4-column strip map fileNote: this is somewhat hard-coded for what we expect for COSI and might be different for GRIPS.